-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(blockifier): update AotNativeExecutor
to AotContractExecutor
#1955
Conversation
Artifacts upload triggered. View details here |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1955 +/- ##
===========================================
+ Coverage 40.10% 67.46% +27.35%
===========================================
Files 26 103 +77
Lines 1895 13913 +12018
Branches 1895 13913 +12018
===========================================
+ Hits 760 9386 +8626
- Misses 1100 4126 +3026
- Partials 35 401 +366 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rodrigo-pino)
crates/blockifier/src/execution/syscalls/syscall_tests/storage_read_write.rs
line 18 at r2 (raw file):
#[cfg_attr( feature = "cairo_native", test_case(FeatureContract::TestContract(CairoVersion::Native), 25920; "Native")
Why was it changed? Shouldn’t the gas amount remain the same?
Code quote:
test_case(FeatureContract::TestContract(CairoVersion::Native), 25920; "Native")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rodrigo-pino)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1)
crates/blockifier/src/execution/syscalls/syscall_tests/storage_read_write.rs
line 18 at r2 (raw file):
Previously, noaov1 (Noa Oved) wrote…
Why was it changed? Shouldn’t the gas amount remain the same?
I also don't understand. There is a difference though in the way the AotContract is compiled to how we did it. My only guess of why it is different, although I don't know to which extent.
We are already familiar with gas usage in Native to be unreliable, changing from version to version all the time. I think is no cause for worries since they are still using the old gas handling mechanism
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1 and @Yoni-Starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Dismissed @noaov1 from a discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @rodrigo-pino)
No description provided.